Fix repair-framework not fully respecting acceptableProblems.

* getCurrentSeverity would report the severity as if 'permit' is false;
  fixed by checking permit inside getCurrentSeverity.
* 'doNotRepair' would cause a problem to never be removed from
  yetToRepair; fixed by having runTests check doNotRepair.

Supporting changes:
* Added tests for acceptableProblems in test-repair-framework.
* Verify that acceptableProblems is not modified after it is used.

@r5664

[MarkM, 2014-02-11 19:34:36]

LGTM

https://codereview.appspot.com/61930043/diff/1/src/com/google/caja/ses/repair...
File src/com/google/caja/ses/repair-framework.js (right):

https://codereview.appspot.com/61930043/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repair-framework.js:516: // This is a useful breakpoint
for answering the question "why is the
Nice. Might as well toss in a commented out

// debugger;

while you're at it.

[kpreid2, 2014-02-11 19:38:16]

https://codereview.appspot.com/61930043/diff/1/src/com/google/caja/ses/repair...
File src/com/google/caja/ses/repair-framework.js (right):

https://codereview.appspot.com/61930043/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repair-framework.js:516: // This is a useful breakpoint
for answering the question "why is the
On 2014/02/11 19:34:37, MarkM wrote:
> Nice. Might as well toss in a commented out
> 
> // debugger;
> 
> while you're at it.

I thought about it and decided not to; someone might prefer to debug with
breakpoints, or just want order-of-events logging.

[MarkM, 2014-02-11 19:40:03]

https://codereview.appspot.com/61930043/diff/1/src/com/google/caja/ses/repair...
File src/com/google/caja/ses/repair-framework.js (right):

https://codereview.appspot.com/61930043/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repair-framework.js:516: // This is a useful breakpoint
for answering the question "why is the
ok. Still LGTM