Issue 6189059: allow SkAutoTUnref to be used syntactially as the object is refs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6189059: allow SkAutoTUnref to be used syntactially as the object is refs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by reed1

Modified:
12 years, 7 months ago

Reviewers:
bungeman

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

allow SkAutoTUnref to be used syntactially as the object is refs Committed: https://code.google.com/p/skia/source/detail?r=3870

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	include/core/SkRefCnt.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bungeman

12 years, 7 months ago (2012-05-08 18:12:30 UTC) #2

On 2012/05/08 17:47:42, reed1 wrote:

LGTM, with the caveat that some day we should unify this with SkTScopedPtr to
avoid the proliferation of entities.

Expand All Messages | Collapse All Messages