Issue 6188054: Fix double->float conversion warning on win32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6188054: Fix double->float conversion warning on win32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by scottmg

Modified:
12 years, 1 month ago

Reviewers:
reed1

Base URL:
http://git.chromium.org/external/skia/src.git@master

Visibility:
Public.

More Reviews

Description

Fix double->float conversion warning on win32 ..\..\third_party\skia\src\core\SkLineClipper.cpp(178) : warning C4305: 'initializing' : truncation from 'double' to 'SkScalar' ..\..\third_party\skia\src\core\SkLineClipper.cpp(178) : warning C4305: 'initializing' : truncation from 'double' to 'SkScalar' BUG=chromium:126483

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/SkLineClipper.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

scottmg

12 years, 1 month ago (2012-05-08 15:34:51 UTC) #3

On 2012/05/08 12:14:37, reed1 wrote:
> committed in rev. 3866

thanks

Expand All Messages | Collapse All Messages