code review 6185047: runtime: fix c compiler warning

runtime: fix c compiler warning

[minux1, 2012-05-03 20:44:57]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2012-05-03 20:45:49]

these two function is unused AFAIK, so another option is to delete them.

[rsc, 2012-05-03 20:47:49]

LGTM

Please use FLUSH instead of USED.

Thanks.

[rsc, 2012-05-03 20:55:02]

If you're sure they're unused by generated Go code,
feel free to delete them.

I'm a little surprised by that, but maybe the floating
point code generation has gotten better than it was.

Russ

[minux1, 2012-05-04 16:07:50]

On 2012/05/03 20:47:49, rsc wrote:
> Please use FLUSH instead of USED.
FLUSH is defined in runtime.h, but as stated in beginning of vlrt_arm.c:

// declared here to avoid include of runtime.h
void    runtime·panicstring(char*);

I think I'd better not to include runtime.h for this file.

[rsc, 2012-05-04 16:12:22]

LGTM

On Fri, May 4, 2012 at 12:07 PM,  <minux.ma@gmail.com> wrote:
> I think I'd better not to include runtime.h for this file.

That's fine.  Did removing the functions entirely not work?

If you can't remove them, please put // FLUSH on the USED lines.

Thanks.
Russ

[minux1, 2012-05-04 17:39:19]

On 2012/05/04 16:12:22, rsc wrote:
> On Fri, May 4, 2012 at 12:07 PM,  <mailto:minux.ma@gmail.com> wrote:
> That's fine.  Did removing the functions entirely not work?
Unfortunately, they are still referenced in cmd/gc/walk.c

[minux1, 2012-05-04 17:39:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=e388ce51be75 ***

runtime: fix c compiler warning

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6185047