Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(358)

Issue 6176045: restore extra slot in sentinal array that was removed in 3825. This extra value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by reed1
Modified:
12 years, 7 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

restore extra slot in sentinal array that was removed in 3825. This extra value is read, but not acted-upon, by spanRec.init(), and so we need to have a valid address/slot allocated. Caught by the remoting_unittests in chrome run using ASAN. Committed: https://code.google.com/p/skia/source/detail?r=3830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/core/SkRegion.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2
reed1
12 years, 7 months ago (2012-05-03 16:14:55 UTC) #1
epoger
12 years, 7 months ago (2012-05-03 16:15:26 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b