Issue 61660043: Issue 362: add Resume() method to ResumableUpload

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61660043: Issue 362: add Resume() method to ResumableUpload (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by peleyal

Modified:
10 years, 8 months ago

Reviewers:
class

CC:
google-api-dotnet-client_googlegroups.com

Base URL:
https://google-api-dotnet-client.googlecode.com/hg/

Visibility:
Public.

More Reviews

Description

Issue 362: add Resume() method to ResumableUpload

Patch Set 3 : First request when resuming should be to query the server where the upload was interrupted at #

Patch Set 5 : add try-catch on resuming #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -83 lines)			Patch
M	Src/GoogleApis.Core/Apis/Requests/RequestBuilder.cs	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs	View	1 2 3	14 chunks	+87 lines, -48 lines	0 comments	Download
M	Src/GoogleApis/Apis/Requests/IClientServiceRequest.cs	View	1 2	2 chunks	+4 lines, -6 lines	0 comments	Download
M	Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs	View	1 2 3 4	8 chunks	+114 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peleyal

https://code.google.com/p/google-api-dotnet-client/issues/detail?id=362

10 years, 8 months ago (2014-02-10 17:15:13 UTC) #1

class

The changes are very minor, just one comment and LGTM. https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs File Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs (right): https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs#newcode393 ...

10 years, 8 months ago (2014-02-11 16:31:45 UTC) #2

peleyal

10 years, 8 months ago (2014-02-12 20:06:38 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media...
File Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs (right):

https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media...
Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs:393: ///
<summary>Asynchronously resumes the upload form the last point it was
interrupted.</summary>
On 2014/02/11 16:31:46, class wrote:
> Might want to add a remark on what the difference between this and the other
> ResumeAsync is.

Done.

Expand All Messages | Collapse All Messages