Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(560)

Issue 6159047: Add function ibus_bus_new_async to create a new IBusBus object and asynchronously connect to the IB… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Peng
Modified:
12 years, 6 months ago
Reviewers:
jason.conti
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Add function ibus_bus_new_async to create a new IBusBus object and asynchronously connect to the IBus daemon. BUG=http://code.google.com/p/ibus/issues/detail?id=1452 TEST=Manually

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -11 lines) Patch
M src/ibusbus.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ibusbus.c View 1 5 chunks +77 lines, -11 lines 0 comments Download

Messages

Total messages: 3
Peng
https://codereview.appspot.com/6159047/diff/1/src/ibusbus.c File src/ibusbus.c (right): https://codereview.appspot.com/6159047/diff/1/src/ibusbus.c#newcode317 src/ibusbus.c:317: g_signal_emit (bus, bus_signals[DISCONNECTED], 0); Is it necessary to fire ...
12 years, 6 months ago (2012-05-08 15:09:36 UTC) #1
jason.conti
On 2012/05/08 15:09:36, Peng wrote: > https://codereview.appspot.com/6159047/diff/1/src/ibusbus.c > File src/ibusbus.c (right): > > https://codereview.appspot.com/6159047/diff/1/src/ibusbus.c#newcode317 > ...
12 years, 6 months ago (2012-05-08 17:45:51 UTC) #2
Peng
12 years, 6 months ago (2012-05-08 17:58:05 UTC) #3
On 2012/05/08 17:45:51, jason.conti wrote:
> On 2012/05/08 15:09:36, Peng wrote:
> > https://codereview.appspot.com/6159047/diff/1/src/ibusbus.c
> > File src/ibusbus.c (right):
> > 
> > https://codereview.appspot.com/6159047/diff/1/src/ibusbus.c#newcode317
> > src/ibusbus.c:317: g_signal_emit (bus, bus_signals[DISCONNECTED], 0);
> > Is it necessary to fire a DISCONNECTED signal here?
> 
> Not necessary.
> 
> With the synchronous version, as soon as ibus_bus_new returns, we can check
> ibus_bus_is_connected to see if connecting to dbus failed. With
> ibus_bus_new_async, we need to wait for the CONNECTED signal, which may never
> arrive. I thought we should include a notification that connecting to dbus
> failed, although a connect-failed signal or similar may be better than reusing
> DISCONNECTED.
> 
> The line can be dropped and it will still work, it is only used in the
> ibus-bus-async.c test to fail if we fail to connect to dbus.

I see. I would like to remove it for now. I will do it, and commit this CL for
you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b