Issue 61510050: Issue 1590: Write a test method for testing regex

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61510050: Issue 1590: Write a test method for testing regex

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Oo Theong Siang

Modified:
10 years, 8 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1590: Write a test method for testing regex

Patch Set 1 #

Total comments: 1

Patch Set 2 : Issue 1590: Write a test method for testing regex #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -51 lines)			Patch
M	src/main/java/teammates/common/util/FieldValidator.java	View	1	7 chunks	+24 lines, -29 lines	0 comments	Download
M	src/main/java/teammates/common/util/StringHelper.java	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/logic/core/CoursesLogic.java	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/main/java/teammates/logic/core/StudentsLogic.java	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/test/java/teammates/test/cases/common/FieldValidatorTest.java	View	1	3 chunks	+77 lines, -14 lines	0 comments	Download
M	src/test/java/teammates/test/cases/common/StringHelperTest.java	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/cases/testdriver/BackDoorTest.java	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/test/java/teammates/test/driver/AssertHelper.java	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 8 months ago (2014-02-13 02:54:54 UTC) #1

https://codereview.appspot.com/61510050/diff/1/src/test/java/teammates/test/c...
File src/test/java/teammates/test/cases/common/FieldValidatorTest.java (right):

https://codereview.appspot.com/61510050/diff/1/src/test/java/teammates/test/c...
src/test/java/teammates/test/cases/common/FieldValidatorTest.java:508: public
void testRegexForEmail() throws Exception {
May be name the method to match the regex name. e.g. test_REGEX_EMAIL

Expand All Messages | Collapse All Messages