Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2145)

Issue 6135045: Add new flags to skdiff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by epoger
Modified:
12 years, 7 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add new flags to skdiff New flags are: --nodiffs: don't write out image diffs or index.html, just generate report on stdout --match: compare files whose filenames contain this substring; if unspecified, compare ALL files this flag may be repeated to add more matching substrings --nomatch: regardless of --match, DO NOT compare files whose filenames contain this substring this flag may be repeated to add more forbidden substrings Also implemented the --threshold flag, which was already documented but not implemented. Committed: https://code.google.com/p/skia/source/detail?r=3806

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -43 lines) Patch
M tools/skdiff_main.cpp View 1 16 chunks +142 lines, -43 lines 0 comments Download

Messages

Total messages: 4
epoger
This CL replaces http://codereview.appspot.com/6118056/ ('skdiff: if outputDir is not specified, don't write out diff files ...
12 years, 7 months ago (2012-04-27 15:54:59 UTC) #1
epoger
On 2012/04/27 15:54:59, epoger wrote: > This CL replaces http://codereview.appspot.com/6118056/ ('skdiff: if outputDir > is ...
12 years, 7 months ago (2012-05-01 02:18:27 UTC) #2
TomH
Sorry! LGTM. https://codereview.appspot.com/6135045/diff/1/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.appspot.com/6135045/diff/1/tools/skdiff_main.cpp#newcode1130 tools/skdiff_main.cpp:1130: } Oh how far we have fallen ...
12 years, 7 months ago (2012-05-01 13:02:18 UTC) #3
epoger
12 years, 7 months ago (2012-05-01 13:05:58 UTC) #4
https://codereview.appspot.com/6135045/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

https://codereview.appspot.com/6135045/diff/1/tools/skdiff_main.cpp#newcode1130
tools/skdiff_main.cpp:1130: }
On 2012/05/01 13:02:18, TomH wrote:
> Oh how far we have fallen from the Unix ideal of silent success.

What good is success if you can't crow about it a little bit?
-D. Trump
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b