Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(240)

Issue 6125047: code review 6125047: ssh: fix flaky TestInvalidServerMessage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by agl1
Modified:
14 years, 5 months ago
Reviewers:
CC:
dave_cheney.net, golang-dev
Visibility:
Public.

Description

ssh: fix flaky TestInvalidServerMessage When shutting down the test, we sometimes see EOF on the server's side of the connection and sometimes ECONNRESET. In the latter case, based on timing, it was possible that the server loop would hit Errorf during shutdown and cause the test to fail.

Patch Set 1 #

Patch Set 2 : diff -r bd78e6211ff8 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r bd78e6211ff8 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r b0c630abc33d https://agl%40golang.org@code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ssh/session_test.go View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://agl%40golang.org@code.google.com/p/go.crypto/
14 years, 5 months ago (2012-04-26 16:41:20 UTC) #1
dave_cheney.net
LGTM. I've never encountered that condition but it could happen if the listening socket starts ...
14 years, 5 months ago (2012-04-26 21:18:10 UTC) #2
agl1
14 years, 5 months ago (2012-04-26 21:19:26 UTC) #3
*** Submitted as
http://code.google.com/p/go/source/detail?r=26239a287fa1&repo=crypto ***

ssh: fix flaky TestInvalidServerMessage

When shutting down the test, we sometimes see EOF on the server's side
of the connection and sometimes ECONNRESET. In the latter case, based
on timing, it was possible that the server loop would hit Errorf during
shutdown and cause the test to fail.

R=dave
CC=golang-dev
http://codereview.appspot.com/6125047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b