Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 6120055: Ugly hack to fix compile error on windows. VC++ does not support C99 and hence snprintf. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by Alok Priyadarshi
Modified:
13 years, 11 months ago
Reviewers:
kbr1, dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Ugly hack to fix compile error on windows. VC++ does not support C99 and hence snprintf. BUG=308 Committed: https://code.google.com/p/angleproject/source/detail?r=1057

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/common/angleutils.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/OutputHLSL.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/PoolAlloc.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/SymbolTable.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/preprocessor/atom.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/preprocessor/cpp.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/preprocessor/tokens.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Alok Priyadarshi
13 years, 11 months ago (2012-04-26 17:59:31 UTC) #1
dgkoch
On 2012/04/26 17:59:31, Alok Priyadarshi wrote: Hi Alok, thanks for catching this. You've missed two ...
13 years, 11 months ago (2012-04-26 19:42:52 UTC) #2
Alok Priyadarshi
DONE
13 years, 11 months ago (2012-04-26 19:57:31 UTC) #3
kbr1
LGTM
13 years, 11 months ago (2012-04-26 21:02:16 UTC) #4
dgkoch
13 years, 11 months ago (2012-04-26 21:18:09 UTC) #5
On 2012/04/26 21:02:16, kbr1 wrote:
> LGTM

Thx Ken & Alok!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b