environs: add UploadTools method

environs/dummy/environs.go

 package dummy
 
 import (
         "bytes"
         "errors"
         "fmt"
         "io"
         "io/ioutil"
         "launchpad.net/juju/go/environs"
         "launchpad.net/juju/go/schema"
@@ skipping 237 matching lines @@
 
 func (e *environ) PutFile(name string, r io.Reader, length int64) error {
         if e.broken {
                 return errBroken
         }
         var buf bytes.Buffer
         _, err := io.Copy(&buf, r)
         if err != nil {
                 return err
         }
         e.state.mu.Lock()

[TheMue, 2012/04/26 17:07:43]

Stumbled over "mu" as identifier. Like "mux" or "mutex" more.

[rog, 2012/04/27 08:52:38]

it's a standard name. try grepping for '^[ 	]*mu[ 	]+sync.Mutex' in the Go
source tree.

         e.state.files[name] = buf.Bytes()
         e.state.mu.Unlock()
         return nil
 }
 
 func (*environ) UploadTools(r io.Reader, length int64, version version.Version) error {
-        return fmt.Errorf("dummy environ does not support executable upload")

[TheMue, 2012/04/26 17:07:43]

To the user we talk about environments. So the error message should be "dummy
environment does ...".

[rog, 2012/04/27 08:52:38]

Done.

+        return fmt.Errorf("dummy environment does not support executable upload")
 }
 
 func (e *environ) GetFile(name string) (io.ReadCloser, error) {
         if e.broken {
                 return nil, errBroken
         }
         e.state.mu.Lock()
         defer e.state.mu.Unlock()
         data, ok := e.state.files[name]
         if !ok {
@@ skipping 20 matching lines @@
         return m.id
 }
 
 func (m *instance) DNSName() (string, error) {
         return m.id + ".dns", nil
 }
 
 func (m *instance) WaitDNSName() (string, error) {
         return m.DNSName()
 }