Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 6112064: code review 6112064: doc/install: document minimum system requirements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by minux1
Modified:
12 years, 10 months ago
Reviewers:
CC:
golang-dev, adg, r
Visibility:
Public.

Description

doc/install: document minimum system requirements Partly copied from CL 5685076.

Patch Set 1 #

Patch Set 2 : diff -r bcd5635a53b0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r bcd5635a53b0 https://code.google.com/p/go/ #

Patch Set 4 : diff -r bcd5635a53b0 https://code.google.com/p/go/ #

Patch Set 5 : diff -r bcd5635a53b0 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 6 : diff -r e154388c7e87 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 7 : diff -r 84e0488c01e1 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M doc/install.html View 1 2 3 4 5 6 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 10 months ago (2012-04-26 18:46:42 UTC) #1
minux1
O_CLOEXEC is introduced in 2.6.23, so I guess it is the minimum requirement for Linux ...
12 years, 10 months ago (2012-04-26 18:55:24 UTC) #2
minux1
From http://code.google.com/p/go/issues/detail?id=2132 it's clear that we only support gcc that comes with Xcode on Mac ...
12 years, 10 months ago (2012-04-26 19:03:28 UTC) #3
adg
I'm not sure about the placement and wording of this. I will take a look ...
12 years, 10 months ago (2012-04-26 19:35:10 UTC) #4
minux1
any thoughts on this?
12 years, 10 months ago (2012-05-11 17:32:41 UTC) #5
r
http://codereview.appspot.com/6112064/diff/5/doc/install.html File doc/install.html (right): http://codereview.appspot.com/6112064/diff/5/doc/install.html#newcode29 doc/install.html:29: Please make sure your system meet these OS and ...
12 years, 10 months ago (2012-05-14 17:20:12 UTC) #6
minux1
Hello golang-dev@googlegroups.com, adg@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 10 months ago (2012-05-14 18:34:43 UTC) #7
r
looks good to me, but please wait for adg to sign off.
12 years, 10 months ago (2012-05-14 18:44:25 UTC) #8
adg
http://codereview.appspot.com/6112064/diff/16001/doc/install.html File doc/install.html (right): http://codereview.appspot.com/6112064/diff/16001/doc/install.html#newcode44 doc/install.html:44: <tr><td>Mac OS X 10.6/10.7</td> <td>amd64, 386</td> <td>Please use the ...
12 years, 10 months ago (2012-05-15 01:05:22 UTC) #9
minux1
PTAL. Also added the note that we don't provide binary distribution for ARM yet.
12 years, 10 months ago (2012-05-16 04:03:48 UTC) #10
adg
12 years, 10 months ago (2012-05-16 04:55:01 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=46a117d22ce2 ***

doc/install: document minimum system requirements
        Partly copied from CL 5685076.

R=golang-dev, adg, r
CC=golang-dev
http://codereview.appspot.com/6112064

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b