Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 6112060: code review 6112060: cmd/go: new tag selection logic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by rsc
Modified:
12 years, 10 months ago
Reviewers:
CC:
golang-dev, bradfitz, r, adg
Visibility:
Public.

Description

cmd/go: new tag selection logic The new logic is "use go1 if it's there, otherwise no tag." Nothing needs to say "I require go1.0.1", and I want to preserve some flexibility in defining what tags mean. Right now (before go1.0.1) there is only one possible tag, "go1", and I'd like to keep it that way.

Patch Set 1 #

Patch Set 2 : diff -r 4d891ff6aedc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a21337b43d7c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -79 lines) Patch
M src/cmd/go/get.go View 1 1 chunk +21 lines, -45 lines 0 comments Download
M src/cmd/go/tag_test.go View 1 1 chunk +37 lines, -34 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 10 months ago (2012-04-25 21:16:27 UTC) #1
rsc
(this needs to be in the go1.0.1 release)
12 years, 10 months ago (2012-04-25 21:17:18 UTC) #2
bradfitz
LGTM Then I assume you're reverting or cleaning this? On Wed, Apr 25, 2012 at ...
12 years, 10 months ago (2012-04-25 21:21:24 UTC) #3
rsc
Before go1.1 yes.
12 years, 10 months ago (2012-04-25 21:34:10 UTC) #4
r
LGTM
12 years, 10 months ago (2012-04-25 21:51:38 UTC) #5
adg
LGTM
12 years, 10 months ago (2012-04-26 09:03:01 UTC) #6
rsc
12 years, 10 months ago (2012-04-26 18:25:54 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=bcd5635a53b0 ***

cmd/go: new tag selection logic

The new logic is "use go1 if it's there, otherwise no tag."
Nothing needs to say "I require go1.0.1", and I want to
preserve some flexibility in defining what tags mean.

Right now (before go1.0.1) there is only one possible tag,
"go1", and I'd like to keep it that way.

R=golang-dev, bradfitz, r, adg
CC=golang-dev
http://codereview.appspot.com/6112060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b