Issue 6112047: Use ibus_engine_update_preedit_with_mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6112047: Use ibus_engine_update_preedit_with_mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Daiki Ueno

Modified:
13 years, 9 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

More Reviews

Description

Use ibus_engine_update_preedit_with_mode. It is unnatural that the preedit is lost on focus changes, if the preedit is not highlighted. This patch makes sure to commit the preedit in that case. BUG=http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661212 TEST=manually

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	src/engine.c	View		4 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages