Issue 6111046: Fix not to send preedit-changed signal when the preedit is not changed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6111046: Fix not to send preedit-changed signal when the preedit is not changed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by fujiwara

Modified:
13 years, 9 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@1.4.y

Visibility:
Public.

More Reviews

Description

Fix not to send preedit-changed signal when the preedit is not changed. BUG=http://code.google.com/p/ibus/issues/detail?id=1445 TEST=Linux desktop

Patch Set 2 : Updated with the latest master. #

Patch Set 3 : Updated with message #2. #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
	M	bus/inputcontext.c	View		1 chunk	+6 lines, -2 lines	0 comments	Download
	M	client/gtk2/ibusimcontext.c	View	1 2	2 chunks	+20 lines, -15 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fujiwara

We could remove some preedit-changed signals when the preedit is not changed.

13 years, 9 months ago (2012-04-24 14:54:03 UTC) #1

Peng

https://codereview.appspot.com/6111046/diff/1/client/gtk2/ibusimcontext.c File client/gtk2/ibusimcontext.c (right): https://codereview.appspot.com/6111046/diff/1/client/gtk2/ibusimcontext.c#newcode1419 client/gtk2/ibusimcontext.c:1419: gboolean flag = FALSE; change order it and IDEBUG ...

13 years, 9 months ago (2012-04-24 15:14:46 UTC) #2

fujiwara

Taking off line, the suggestion was if ibusimcontext->preedit_visible == TRUE and ibusimcontext->preedit_string is a string, ...

13 years, 9 months ago (2012-04-25 02:56:51 UTC) #3

Peng

13 years, 9 months ago (2012-04-25 14:55:06 UTC) #4

lgtm. Does this problem exist in master branch. If yes, please port it to
master.

Expand All Messages | Collapse All Messages