Issue 778: Domita DOMContentLoaded and Window 'load' events

Domita should fire [simulated] DOMContentLoaded and Window 'load' events at
the appropriate times.


Submitted @3505

[ihab.awad, 2009-05-13 22:48:36]

LGTM++ (see comments)

http://codereview.appspot.com/61051/diff/1/12
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/61051/diff/1/12#newcode3303
Line 3303: addEventListener: ___.func(function (name, listener, useCapture) {
Why not ___.frozenFunc?

http://codereview.appspot.com/61051/diff/1/12#newcode3309
Line 3309: removeEventListener: ___.func(function (name, listener, useCapture) {
Why not ___.frozenFunc?

http://codereview.appspot.com/61051/diff/1/12#newcode3319
Line 3319: })
Why removed DispatchEvent?

http://codereview.appspot.com/61051/diff/1/11
File src/com/google/caja/plugin/html-emitter.js (right):

http://codereview.appspot.com/61051/diff/1/11#newcode183
Line 183: setTimeout(
Should each listener be invoked in a separate top-level event (=== setTimeout
call)?

http://codereview.appspot.com/61051/diff/1/11#newcode185
Line 185: var listeners = doc.onLoadListeners___;
It would probably be more encapsulated-like to schlep this code into class
TameHTMLDocument.

[MikeSamuel, 2009-05-19 00:22:46]

http://codereview.appspot.com/61051/diff/1/12
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/61051/diff/1/12#newcode3303
Line 3303: addEventListener: ___.func(function (name, listener, useCapture) {
On 2009/05/13 22:48:36, ihab.awad wrote:
> Why not ___.frozenFunc?

Done.

http://codereview.appspot.com/61051/diff/1/12#newcode3309
Line 3309: removeEventListener: ___.func(function (name, listener, useCapture) {
On 2009/05/13 22:48:36, ihab.awad wrote:
> Why not ___.frozenFunc?

Done.

http://codereview.appspot.com/61051/diff/1/12#newcode3319
Line 3319: })
Because it did nothing.

http://codereview.appspot.com/61051/diff/1/11
File src/com/google/caja/plugin/html-emitter.js (right):

http://codereview.appspot.com/61051/diff/1/11#newcode183
Line 183: setTimeout(
On 2009/05/13 22:48:36, ihab.awad wrote:
> Should each listener be invoked in a separate top-level event (=== setTimeout
> call)?

Yes.  Otherwise the list of listeners will not properly correlate with add and
remove calls that occur after the window onload event but before the first
listener is fired.
And it's easier for firebug et al to intercept exceptions if they're done
separately.

http://codereview.appspot.com/61051/diff/1/11#newcode185
Line 185: var listeners = doc.onLoadListeners___;
On 2009/05/13 22:48:36, ihab.awad wrote:
> It would probably be more encapsulated-like to schlep this code into class
> TameHTMLDocument.

Done.

[MikeSamuel, 2009-05-20 05:33:05]

http://codereview.appspot.com/61051/diff/1/12
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/61051/diff/1/12#newcode3319
Line 3319: })
On 2009/05/19 00:22:47, MikeSamuel wrote:
> Because it did nothing.

Put back.