Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(541)

Issue 6105045: The default implementation in flex only handles LF characters. GLSL supports all three newline char… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 12 months ago by Alok Priyadarshi
Modified:
13 years, 11 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The default implementation in flex only handles LF characters. GLSL supports all three newline characters - LF, CR, and CR+LF. Use a custom newline handler. Committed: https://code.google.com/p/angleproject/source/detail?r=1049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -118 lines) Patch
M src/compiler/preprocessor/new/pp.l View 2 chunks +7 lines, -2 lines 0 comments Download
M src/compiler/preprocessor/new/pp_lex.cpp View 9 chunks +84 lines, -116 lines 0 comments Download

Messages

Total messages: 2
Alok Priyadarshi
13 years, 12 months ago (2012-04-20 22:35:43 UTC) #1
kbr1
13 years, 11 months ago (2012-04-23 19:17:23 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b