code review 6104046: go.crypto/ssh: server_test should bind to localhost only

go.crypto/ssh: server_test should bind to localhost only

Hopefully fix build error under windows.

Binding to the wildcard is poor form for our darwin users
as it triggers the firewall popup. Dialing the wildcard
looks like it's implementation specific as well.

[dave_cheney.net, 2012-04-21 00:33:24]

Hello agl@golang.org, kardianos@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[agl1, 2012-04-21 00:36:55]

LGTM
On Apr 20, 2012 8:33 PM, <dave@cheney.net> wrote:

> Reviewers: agl1, kardia,
>
> Message:
> Hello agl@golang.org, kardianos@gmail.com (cc:
> golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.**crypto<https://code.google.com/p/go.crypto>
>
>
> Description:
> go.crypto/ssh: server_test should bind to localhost only
>
> Hopefully fix build error under windows.
>
> Binding to the wildcard is poor form for our darwin users
> as it triggers the firewall popup. Dialing the wildcard
> looks like it's implementation specific as well.
>
> Please review this at
http://codereview.appspot.com/**6104046/<http://codereview.appspot.com/6104046/>
>
> Affected files:
>  M ssh/server_test.go
>
>
> Index: ssh/server_test.go
> ==============================**==============================**=======
> --- a/ssh/server_test.go
> +++ b/ssh/server_test.go
> @@ -120,7 +120,7 @@
>                t.Fatalf("Failed to parse private key: %s", err.Error())
>        }
>
> -       listener, err := Listen("tcp", ":0", config)
> +       listener, err := Listen("tcp", "127.0.0.1:0", config)
>        if err != nil {
>                t.Fatalf("Bind error: %s", err)
>        }
>
>
>

[dave_cheney.net, 2012-04-21 00:38:03]

Ta. I'll wait for the current builders to render their verdict, then
I'll submit.

On Sat, Apr 21, 2012 at 10:36 AM, Adam Langley <agl@golang.org> wrote:
> LGTM
>
> On Apr 20, 2012 8:33 PM, <dave@cheney.net> wrote:
>>
>> Reviewers: agl1, kardia,
>>
>> Message:
>> Hello agl@golang.org, kardianos@gmail.com (cc:
>> golang-dev@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go.crypto
>>
>>
>> Description:
>> go.crypto/ssh: server_test should bind to localhost only
>>
>> Hopefully fix build error under windows.
>>
>> Binding to the wildcard is poor form for our darwin users
>> as it triggers the firewall popup. Dialing the wildcard
>> looks like it's implementation specific as well.
>>
>> Please review this at http://codereview.appspot.com/6104046/
>>
>> Affected files:
>>  M ssh/server_test.go
>>
>>
>> Index: ssh/server_test.go
>> ===================================================================
>> --- a/ssh/server_test.go
>> +++ b/ssh/server_test.go
>> @@ -120,7 +120,7 @@
>>                t.Fatalf("Failed to parse private key: %s", err.Error())
>>        }
>>
>> -       listener, err := Listen("tcp", ":0", config)
>> +       listener, err := Listen("tcp", "127.0.0.1:0", config)
>>        if err != nil {
>>                t.Fatalf("Bind error: %s", err)
>>        }
>>
>>
>

[dave_cheney.net, 2012-04-21 00:45:01]

*** Submitted as
http://code.google.com/p/go/source/detail?r=80f56bcd6343&repo=crypto ***

go.crypto/ssh: server_test should bind to localhost only

Hopefully fix build error under windows.

Binding to the wildcard is poor form for our darwin users
as it triggers the firewall popup. Dialing the wildcard
looks like it's implementation specific as well.

R=agl, kardianos
CC=golang-dev
http://codereview.appspot.com/6104046