Issue 6100049: code review 6100049: mksysinfo: More fixes to emulate master Go library.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6100049: code review 6100049: mksysinfo: More fixes to emulate master Go library. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by iant

Modified:
13 years ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

mksysinfo: More fixes to emulate master Go library.

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -13 lines)			Patch
M	libgo/config.h.in	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	libgo/configure	View	1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/configure.ac	View	1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/go/os/stat.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	libgo/go/os/stat_solaris.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	libgo/go/syscall/libcall_linux.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/go/syscall/socket.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/mksysinfo.sh	View	10 chunks	+19 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

13 years ago (2012-04-22 20:07:01 UTC) #1

iant

13 years ago (2012-04-22 20:07:09 UTC) #2

*** Submitted as
http://code.google.com/p/gofrontend/source/detail?r=e746e3770f15 ***

mksysinfo: More fixes to emulate master Go library.

R=iant
CC=gofrontend-dev
http://codereview.appspot.com/6100049

Expand All Messages | Collapse All Messages