Issue 60870046: JS/CPP/JAVA: libphonenumber v5.9.4 metadata updates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60870046: JS/CPP/JAVA: libphonenumber v5.9.4 metadata updates (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by Shaopeng

Modified:
10 years, 3 months ago

Reviewers:
davinci_google

CC:
lararennie

Base URL:
http://libphonenumber.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

JS/CPP/JAVA: libphonenumber v5.9.4 metadata updates Committed: https://code.google.com/p/libphonenumber/source/detail?r=648

Patch Set 1 #

Created: 10 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1534 lines, -1779 lines)			Patch
M	cpp/src/phonenumbers/short_metadata.cc	View	1 chunk	+1065 lines, -1054 lines	0 comments	Download
M	debian/changelog	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	java/release_notes.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	javascript/i18n/phonenumbers/demo-compiled.js	View	1 chunk	+0 lines, -504 lines	0 comments	Download
M	javascript/i18n/phonenumbers/metadata.js	View	25 chunks	+73 lines, -46 lines	0 comments	Download
M	javascript/i18n/phonenumbers/metadatalite.js	View	25 chunks	+73 lines, -46 lines	0 comments	Download
M	resources/PhoneNumberMetadata.xml	View	33 chunks	+138 lines, -115 lines	0 comments	Download
M	resources/ShortNumberMetadata.xml	View	3 chunks	+73 lines, -7 lines	0 comments	Download
M	resources/carrier/en/1.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	resources/carrier/en/213.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	resources/carrier/en/226.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	resources/carrier/en/229.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	resources/carrier/en/234.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	resources/carrier/en/267.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	resources/carrier/en/373.txt	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	resources/carrier/en/389.txt	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	resources/carrier/en/48.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	resources/carrier/en/49.txt	View	1 chunk	+15 lines, -1 line	0 comments	Download
M	resources/carrier/en/506.txt	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	resources/carrier/en/598.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	resources/carrier/en/91.txt	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	resources/carrier/en/92.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Shaopeng

Committed patchset #1 manually as r648 (presubmit successful).

10 years, 3 months ago (2014-02-07 13:23:52 UTC) #3

davinci_google

10 years, 3 months ago (2014-02-10 20:12:46 UTC) #4

Message was sent while issue was closed.

On 2014/02/07 13:23:52, Shaopeng wrote:
> Committed patchset #1 manually as r648 (presubmit successful).

demo-compiled.js appears to have been accidentally deleted.

Expand All Messages | Collapse All Messages