Fixes for drawing through an SkGPipe.

Fixes for drawing through an SkGPipe.

Implement SkGPipeCanvas::drawBitmap.

Fix a bug where needOpBytes did not necessarily provide as
many bytes as requested.

Fix a bug where needOpBytes would wipe old data without
calling notify.

Register SkEmbossMaskFilter so it can be flattened.

Override drawBitmapNine (currently unimplemented) so an
SkGPipeCanvas does not call its base class' method (which
would fail).
Committed: https://code.google.com/p/skia/source/detail?r=3741

[reed1, 2012-04-19 18:19:29]

minor: does we use 1 or 0 to indicated a missing parameter like a paint, in
other cases (e.g. pictures)?

https://codereview.appspot.com/6071045/diff/3001/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (left):

https://codereview.appspot.com/6071045/diff/3001/src/pipe/SkGPipeRead.cpp#old...
src/pipe/SkGPipeRead.cpp:332: UNIMPLEMENTED
// This is the brute-force solution
// TODO: add the notion of a shared, counted for large immutable resources

[Leon, 2012-04-20 14:20:09]

On Thu, Apr 19, 2012 at 2:19 PM, <reed@google.com> wrote:

> minor: does we use 1 or 0 to indicated a missing parameter like a paint,
> in other cases (e.g. pictures)?
>

Fixed. I now pass TRUE to indicate that we should supply a paint to
drawBitmap, and FALSE to indicate that NULL should be used.

>
>
> https://codereview.appspot.**com/6071045/diff/3001/src/**
>
pipe/SkGPipeRead.cpp<https://codereview.appspot.com/6071045/diff/3001/src/pipe/SkGPipeRead.cpp>
> File src/pipe/SkGPipeRead.cpp (left):
>
> https://codereview.appspot.**com/6071045/diff/3001/src/**
>
pipe/SkGPipeRead.cpp#**oldcode332<https://codereview.appspot.com/6071045/diff/3001/src/pipe/SkGPipeRead.cpp#oldcode332>
> src/pipe/SkGPipeRead.cpp:332: UNIMPLEMENTED
> // This is the brute-force solution
> // TODO: add the notion of a shared, counted for large immutable
> resources
>
>
https://codereview.appspot.**com/6071045/<https://codereview.appspot.com/6071...
>

Added.

-- 
Leon Scroggins III
scroggo@google.com

[Leon, 2012-04-20 16:22:54]

Added a comment regarding CrossProcess

[reed1, 2012-04-20 17:34:09]

lgtm