Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(502)

Issue 6063054: code review 6063054: doc: don't wrap package names in directory listing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by adg
Modified:
12 years, 11 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

doc: don't wrap package names in directory listing Fixes issue 3522.

Patch Set 1 #

Patch Set 2 : diff -r 362b760ecfc7 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 3 : diff -r 0efe48e1edcf https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M doc/style.css View 1 2 chunks +3 lines, -2 lines 0 comments Download
M lib/godoc/package.html View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
12 years, 11 months ago (2012-04-19 20:51:07 UTC) #1
dsymonds
It would be clearer and more robust to apply a class to that TD in ...
12 years, 11 months ago (2012-04-19 23:02:39 UTC) #2
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 11 months ago (2012-04-20 13:41:05 UTC) #3
dsymonds
LGTM http://codereview.appspot.com/6063054/diff/4001/doc/style.css File doc/style.css (right): http://codereview.appspot.com/6063054/diff/4001/doc/style.css#newcode111 doc/style.css:111: div#page.wide table.dir td.name { I'd probably use "package-name" ...
12 years, 11 months ago (2012-04-20 13:42:59 UTC) #4
adg
On 20 April 2012 09:42, <dsymonds@golang.org> wrote: > I'd probably use "package-name" as the class, ...
12 years, 11 months ago (2012-04-20 14:04:18 UTC) #5
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=f4f63fb397c6 *** doc: don't wrap package names in directory listing Fixes issue ...
12 years, 11 months ago (2012-04-20 14:04:18 UTC) #6
dsymonds
12 years, 11 months ago (2012-04-20 23:01:26 UTC) #7
On Apr 21, 2012 12:04 AM, "Andrew Gerrand" <adg@golang.org> wrote:

> On 20 April 2012 09:42,  <dsymonds@golang.org> wrote:
> > I'd probably use "package-name" as the class, but this is fine.
>
> Its a directory name, not a package name. Hence .dir .name.

See the CL description for the source of my confusion.  ;-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b