Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(621)

Issue 6063053: code review 6063053: syscall: add Termios support on darwin (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by fss
Modified:
8 years, 8 months ago
Reviewers:
CC:
dfc, kevlar, dho, rsc, minux1, golang-dev
Visibility:
Public.

Description

syscall: add Termios support on darwin Update issue 3316.

Patch Set 1 #

Patch Set 2 : diff -r 362b760ecfc7 https://code.google.com/p/go #

Patch Set 3 : diff -r 362b760ecfc7 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 6c742b3b04d1 https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r 850cadc5bc9f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -0 lines) Patch
M src/pkg/syscall/mkerrors.sh View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_darwin.go View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_386.go View 1 2 3 12 chunks +93 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_amd64.go View 1 2 3 12 chunks +93 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_386.go View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_amd64.go View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14
fss
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 9 months ago (2012-04-19 17:17:11 UTC) #1
fss
Ping?
8 years, 9 months ago (2012-04-23 03:18:37 UTC) #2
dfc
On 2012/04/23 03:18:37, fsouza wrote: > Ping? I'm not sure what the policy is currently ...
8 years, 9 months ago (2012-04-23 08:56:58 UTC) #3
kevlar
FWIW, these are relatively straightforward to do directly in terminal packages. I'd only put them ...
8 years, 9 months ago (2012-04-23 20:19:35 UTC) #4
fss
On 2012/04/23 20:19:35, kevlar wrote: > FWIW, these are relatively straightforward to do directly in ...
8 years, 9 months ago (2012-04-24 13:25:53 UTC) #5
dho
Op 23 april 2012 04:56 heeft <dave@cheney.net> het volgende geschreven: > On 2012/04/23 03:18:37, fsouza ...
8 years, 9 months ago (2012-04-24 14:18:53 UTC) #6
rsc
See the note at the top of the z* files. http://codereview.appspot.com/6063053/diff/5001/src/pkg/syscall/zerrors_darwin_386.go File src/pkg/syscall/zerrors_darwin_386.go (left): http://codereview.appspot.com/6063053/diff/5001/src/pkg/syscall/zerrors_darwin_386.go#oldcode149 ...
8 years, 8 months ago (2012-04-25 01:42:22 UTC) #7
fss
On 2012/04/25 01:42:22, rsc wrote: > See the note at the top of the z* ...
8 years, 8 months ago (2012-04-26 23:59:41 UTC) #8
fss
Please take another look. I've changed mkerrors.sh to include termios.h constants in go files, and ...
8 years, 8 months ago (2012-04-27 04:52:04 UTC) #9
minux1
https://codereview.appspot.com/6063053/diff/18001/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): https://codereview.appspot.com/6063053/diff/18001/src/pkg/syscall/mkerrors.sh#newcode178 src/pkg/syscall/mkerrors.sh:178: $2 ~ /^V[A-Z0-9]+$/ || please use tab to indent ...
8 years, 8 months ago (2012-04-27 04:58:01 UTC) #10
fss
ptal https://codereview.appspot.com/6063053/diff/18001/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): https://codereview.appspot.com/6063053/diff/18001/src/pkg/syscall/mkerrors.sh#newcode178 src/pkg/syscall/mkerrors.sh:178: $2 ~ /^V[A-Z0-9]+$/ || On 2012/04/27 04:58:01, minux ...
8 years, 8 months ago (2012-04-27 05:30:01 UTC) #11
fss
ping?
8 years, 8 months ago (2012-05-01 04:27:53 UTC) #12
rsc
LGTM Will submit later if no one beats me to it.
8 years, 8 months ago (2012-05-01 23:05:36 UTC) #13
rsc
8 years, 8 months ago (2012-05-03 21:33:23 UTC) #14
*** Submitted as http://code.google.com/p/go/source/detail?r=b0f36fc20ab2 ***

syscall: add Termios support on darwin

Update issue 3316.

R=dave, kevlar, devon.odell, rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6063053

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b