Issue 606041: code review 606041: gofmt: more consistent formatting of const/var decls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 606041: code review 606041: gofmt: more consistent formatting of const/var decls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by gri

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev, r

Visibility:
Public.

Description

gofmt: more consistent formatting of const/var decls - gofmt -w src misc - only manually modified file: src/pkg/go/printer/nodes.go

Patch Set 1 #

Patch Set 2 : code review 606041: gofmt: more consistent formatting of const/var decls #

Patch Set 3 : code review 606041: gofmt: more consistent formatting of const/var decls #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -88 lines)			Patch
M	src/cmd/godoc/main.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/ast/scope.go	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	5 chunks	+19 lines, -27 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.golden	View	1 chunk	+30 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/comments.input	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.golden	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.raw	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/go/scanner/errors.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/scanner/scanner.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/log/log.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/rand/rand_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/regexp/regexp.go	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	src/pkg/runtime/type.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/testing/regexp.go	View	1 chunk	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com, r), I'd like you to review this change.

15 years ago (2010-03-16 22:46:45 UTC) #1

gri

15 years ago (2010-03-16 23:45:57 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=36549fbd26e3 ***

gofmt: more consistent formatting of const/var decls
- gofmt -w src misc
- only manually modified file: src/pkg/go/printer/nodes.go

R=rsc
CC=golang-dev, r
http://codereview.appspot.com/606041

Expand All Messages | Collapse All Messages