Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 60560043: Do not move property panel when it's always shown. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by fujiwara
Modified:
10 years, 1 month ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Do not let property panel follow cursor when it's always shown.

Patch Set 1 #

Patch Set 2 : Fixed typo. #

Patch Set 3 : Fixed copyright. #

Total comments: 2

Patch Set 4 : Updated with message #3. #

Total comments: 2

Patch Set 5 : Updated with message #5. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -4 lines) Patch
M data/ibus.schemas.in View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M po/POTFILES.in View 1 chunk +1 line, -0 lines 0 comments Download
M po/POTFILES.skip View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gtk3/panel.vala View 1 2 3 4 4 chunks +16 lines, -1 line 0 comments Download
M ui/gtk3/propertypanel.vala View 1 2 3 4 7 chunks +95 lines, -3 lines 0 comments Download

Messages

Total messages: 6
fujiwara
10 years, 1 month ago (2014-02-06 09:13:51 UTC) #1
Peng
On 2014/02/06 09:13:51, fujiwara wrote:
10 years, 1 month ago (2014-02-06 14:28:58 UTC) #2
Peng
https://codereview.appspot.com/60560043/diff/10006/data/ibus.schemas.in File data/ibus.schemas.in (right): https://codereview.appspot.com/60560043/diff/10006/data/ibus.schemas.in#newcode211 data/ibus.schemas.in:211: <long>Move when panel is always shown</long> This description is ...
10 years, 1 month ago (2014-02-07 18:46:43 UTC) #3
fujiwara
https://codereview.appspot.com/60560043/diff/10006/data/ibus.schemas.in File data/ibus.schemas.in (right): https://codereview.appspot.com/60560043/diff/10006/data/ibus.schemas.in#newcode211 data/ibus.schemas.in:211: <long>Move when panel is always shown</long> On 2014/02/07 18:46:43, ...
10 years, 1 month ago (2014-02-10 03:29:01 UTC) #4
Peng
lgtm with one comment. https://codereview.appspot.com/60560043/diff/50001/data/ibus.schemas.in File data/ibus.schemas.in (right): https://codereview.appspot.com/60560043/diff/50001/data/ibus.schemas.in#newcode205 data/ibus.schemas.in:205: <applyto>/desktop/ibus/panel/move-when-always-shown</applyto> follow-input-cursor-when-always-shown?
10 years, 1 month ago (2014-02-10 15:01:04 UTC) #5
fujiwara
10 years, 1 month ago (2014-02-12 03:46:13 UTC) #6
https://codereview.appspot.com/60560043/diff/50001/data/ibus.schemas.in
File data/ibus.schemas.in (right):

https://codereview.appspot.com/60560043/diff/50001/data/ibus.schemas.in#newco...
data/ibus.schemas.in:205:
<applyto>/desktop/ibus/panel/move-when-always-shown</applyto>
On 2014/02/10 15:01:05, Peng wrote:
> follow-input-cursor-when-always-shown?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b