Issue 6055050: Fix bug where SkGPipe'ed clips do not happen.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6055050: Fix bug where SkGPipe'ed clips do not happen. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Leon

Modified:
12 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix bug where SkGPipe'ed clips do not happen. Modify SkGPipeCanvas::clipRect and ::clipPath so they correctly override the SkCanvas versions, and therefore get called. Also use SK_OVERRIDE for its virtual functions to help catch this in the future. BUG=572 Committed: https://code.google.com/p/skia/source/detail?r=3718

Patch Set 1 #

Patch Set 2 : #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -36 lines)			Patch
	M	src/pipe/SkGPipeRead.cpp	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
	M	src/pipe/SkGPipeWrite.cpp	View	1	2 chunks	+42 lines, -34 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages