Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 6052049: [google/google-main] Fix for unused variable warning in libgcov.c

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by tejohnson
Modified:
6 years, 6 months ago
Reviewers:
davidxl
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/libgcc/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M libgcov.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
tejohnson
I have a patch to fix a compile time warning about an unused variable due ...
8 years, 10 months ago (2012-04-17 18:40:09 UTC) #1
davidxl
8 years, 10 months ago (2012-04-17 18:57:13 UTC) #2
ok.

David

On Tue, Apr 17, 2012 at 11:40 AM, Teresa Johnson <tejohnson@google.com> wrote:
> I have a patch to fix a compile time warning about an unused variable due
> to the use being guarded by #ifndef __GCOV_KERNEL__.
>
> Tested with bootstrap. Ok for google-main?
>
> Teresa
>
> 2012-04-17   Teresa Johnson  <tejohnson@google.com>
>
>        Google ref b/5910724.
>        * libgcc/libgcov.c (gcov_cur_module_id): Guard definition under
>        #ifndef __GCOV_KERNEL__.
>
> Index: libgcov.c
> ===================================================================
> --- libgcov.c   (revision 186282)
> +++ libgcov.c   (working copy)
> @@ -153,10 +153,10 @@ static gcov_unsigned_t gcov_crc32;
>
>  /* Size of the longest file name. */
>  static size_t gcov_max_filename = 0;
> -#endif /* __GCOV_KERNEL__ */
>
>  /* Unique identifier assigned to each module (object file).  */
>  static gcov_unsigned_t gcov_cur_module_id = 0;
> +#endif /* __GCOV_KERNEL__ */
>
>  /* Pointer to the direct-call counters (per call-site counters).
>    Initialized by the caller.  */
>
> --
> This patch is available for review at http://codereview.appspot.com/6052049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b