Issue 6050047: In SampleWindow, pass ownership of menus to SkWindow, so it can safely

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6050047: In SampleWindow, pass ownership of menus to SkWindow, so it can safely (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Leon

Modified:
12 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

In SampleWindow, pass ownership of menus to SkWindow, so it can safely delete them in its destructor. BUG=557 TEST=Run SampleApp on linux. Then press escape. Committed: https://code.google.com/p/skia/source/detail?r=3719

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -46 lines)			Patch
	M	samplecode/SampleApp.h	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
	M	samplecode/SampleApp.cpp	View	1 2	5 chunks	+45 lines, -43 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm w/ comment suggestion about ownership https://codereview.appspot.com/6050047/diff/2001/samplecode/SampleApp.h File samplecode/SampleApp.h (left): https://codereview.appspot.com/6050047/diff/2001/samplecode/SampleApp.h#oldcode177 samplecode/SampleApp.h:177: SkOSMenu fAppMenu; // ...

12 years, 4 months ago (2012-04-18 13:38:31 UTC) #2

Leon

12 years, 4 months ago (2012-04-18 14:07:37 UTC) #3

https://codereview.appspot.com/6050047/diff/2001/samplecode/SampleApp.h
File samplecode/SampleApp.h (left):

https://codereview.appspot.com/6050047/diff/2001/samplecode/SampleApp.h#oldco...
samplecode/SampleApp.h:177: SkOSMenu fAppMenu;
On 2012/04/18 13:38:31, reed1 wrote:
> // We pass ownership of this to SkWindow, when we call addMenu()

Done.

https://codereview.appspot.com/6050047/diff/2001/samplecode/SampleApp.h#oldco...
samplecode/SampleApp.h:179: SkOSMenu fSlideMenu;
On 2012/04/18 13:38:31, reed1 wrote:
> ditto

Done.

Expand All Messages | Collapse All Messages