Issue 6038043: Added tests for identifiers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6038043: Added tests for identifiers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by Alok Priyadarshi

Modified:
13 years, 12 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added tests for identifiers. Committed: https://code.google.com/p/angleproject/source/detail?r=1042

Patch Set 2 : #

Created: 13 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -0 lines)			Patch
	M	tests/build_tests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/preprocessor_tests/identifier_test.cpp	View	1	1 chunk	+149 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

LGTM with same question as before about negative tests. http://codereview.appspot.com/6038043/diff/1/tests/preprocessor_tests/identifier_test.cpp File tests/preprocessor_tests/identifier_test.cpp (right): http://codereview.appspot.com/6038043/diff/1/tests/preprocessor_tests/identifier_test.cpp#newcode104 tests/preprocessor_tests/identifier_test.cpp:104: ...

13 years, 12 months ago (2012-04-13 22:18:46 UTC) #2

Alok Priyadarshi

13 years, 12 months ago (2012-04-13 22:43:09 UTC) #3

Added one non-combinatorial test IdentifierTestAllCharacters, which has all
possible characters in one test string. It also uses '_' as separator.

I will experiment with catch-all rule and add negative tests.

On 2012/04/13 22:18:46, kbr1 wrote:
> LGTM with same question as before about negative tests.
> 
>
http://codereview.appspot.com/6038043/diff/1/tests/preprocessor_tests/identif...
> File tests/preprocessor_tests/identifier_test.cpp (right):
> 
>
http://codereview.appspot.com/6038043/diff/1/tests/preprocessor_tests/identif...
> tests/preprocessor_tests/identifier_test.cpp:104: testing::Values('_')));
> Not to introduce too many combinatorial possibilities, but you probably should
> test the case where "_" is used as a separator in variable names, e.g.
> [a-f]"_"[a-f], rather than just as a prefix or suffix.

Expand All Messages | Collapse All Messages