Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1329)

Issue 6035050: code review 6035050: encoding/json: Fix panic when trying to unmarshal the e... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by chaten
Modified:
7 years, 8 months ago
Reviewers:
CC:
rsc, bradfitz, golang-dev
Visibility:
Public.

Description

encoding/json: Fix panic when trying to unmarshal the empty string into an integer Fixes issue 3450.

Patch Set 1 #

Patch Set 2 : diff -r 0324cadd9b98 https://code.google.com/p/go #

Total comments: 3

Patch Set 3 : diff -r 5a1d471de6d2 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/pkg/encoding/json/decode.go View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6
chaten
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 1 month ago (2012-04-14 21:33:25 UTC) #1
chaten
*ping*
8 years, 1 month ago (2012-04-21 05:57:14 UTC) #2
rsc
http://codereview.appspot.com/6035050/diff/2001/src/pkg/encoding/json/decode.go File src/pkg/encoding/json/decode.go (right): http://codereview.appspot.com/6035050/diff/2001/src/pkg/encoding/json/decode.go#newcode592 src/pkg/encoding/json/decode.go:592: //Empty string given I don't see why the empty ...
8 years, 1 month ago (2012-04-23 13:57:54 UTC) #3
chaten
Hello rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 1 month ago (2012-04-29 07:49:58 UTC) #4
rsc
LGTM
8 years, 1 month ago (2012-05-03 21:34:08 UTC) #5
rsc
8 years, 1 month ago (2012-05-03 21:35:47 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=7ee60b35f644 ***

encoding/json: Fix panic when trying to unmarshal the empty string into an
integer

Fixes issue 3450.

R=rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/6035050

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b