Issue 6031059: Add options to disable to build UI and engines.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6031059: Add options to disable to build UI and engines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by fujiwara

Modified:
12 years, 2 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Add options to disable to build UI and engines. TEST=Linux desktop

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
	M	Makefile.am	View		2 chunks	+7 lines, -1 line	0 comments	Download
	M	configure.ac	View	1	2 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fujiwara

As I explained another CL, there are many functions are missed in both ui and ...

12 years, 2 months ago (2012-04-16 07:50:02 UTC) #1

Peng

12 years, 2 months ago (2012-04-16 13:00:44 UTC) #2

lgtm with comments.

http://codereview.appspot.com/6031059/diff/1/configure.ac
File configure.ac (right):

http://codereview.appspot.com/6031059/diff/1/configure.ac#newcode475
configure.ac:475: [Use ibus ui]),
Disable ibus default user interface.

http://codereview.appspot.com/6031059/diff/1/configure.ac#newcode487
configure.ac:487: [Use ibus engine]),
Disable ibus simple engine.

Expand All Messages | Collapse All Messages