Issue 60300043: Permit AppAssertionCredentials to specify the service account to use

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60300043: Permit AppAssertionCredentials to specify the service account to use

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rohwer

Modified:
11 years, 5 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Permit AppAssertionCredentials to specify the service account to use

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	oauth2client/appengine.py	View		2 chunks	+6 lines, -1 line	0 comments	Download
	M	tests/test_oauth2client_appengine.py	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rohwer

On 2014/02/05 16:01:57, jcgregorio_google wrote: > LGTM Thanks for the quick review :-) But, I'm ...

11 years, 5 months ago (2014-02-05 18:50:53 UTC) #2

jcgregorio_google

Committed in https://code.google.com/p/google-api-python-client/source/detail?r=54dc473e19f67cf7361f977b282fa237a21508e5 On 2014/02/05 18:50:53, rohwer wrote: > On 2014/02/05 16:01:57, jcgregorio_google wrote: > ...

11 years, 5 months ago (2014-02-05 19:27:49 UTC) #3

rohwer

11 years, 5 months ago (2014-02-05 19:29:12 UTC) #4

On 2014/02/05 19:27:49, jcgregorio_google wrote:
> Committed in
>
https://code.google.com/p/google-api-python-client/source/detail?r=54dc473e19...
> 
> On 2014/02/05 18:50:53, rohwer wrote:
> > On 2014/02/05 16:01:57, jcgregorio_google wrote:
> > > LGTM
> > 
> > Thanks for the quick review :-)
> > 
> > But, I'm not sure how to submit.
> > 
> > I guess I can't push the commit myself (I get 403s), do you pull it? (Please
> > excuse my ignorance, I'm new to Hg).
> > 
> > I've committed locally, and get this: "committed changeset 627:356038d76548"
> > 
> > The local repo is at
> >
rohwer.sfo.corp.google.com/usr/local/google/home/rohwer/1/oauth2client/trunk/
> > 
> > Thanks!

Awesome, thanks!

Expand All Messages | Collapse All Messages