Issue 6028044: CPP: libphonenumber 4.7.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6028044: CPP: libphonenumber 4.7. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by pliard1

Modified:
12 years ago

Reviewers:
lararennie, pliard, shaopengjia

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: libphonenumber 4.7. This is mainly a metadata update. Modified files: cpp/src/phonenumbers/lite_metadata.cc cpp/src/phonenumbers/metadata.cc cpp/src/phonenumbers/phonenumberutil.cc cpp/test/phonenumbers/phonenumbermatcher_test.cc Committed: https://code.google.com/p/libphonenumber/source/detail?r=439

Patch Set 1 #

Created: 12 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	cpp/src/phonenumbers/phonenumberutil.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	cpp/test/phonenumbers/phonenumbermatcher_test.cc	View		5 chunks	+15 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

pliard

12 years ago (2012-04-13 10:07:36 UTC) #3

Committed as r439.

Thanks for the quick review :)

On Fri, Apr 13, 2012 at 12:02 PM, <lararennie@google.com> wrote:

> On 2012/04/13 09:49:27, pliard1 wrote:
>
> LGTM
>
>
http://codereview.appspot.com/**6028044/<http://codereview.appspot.com/6028044/>
>

Expand All Messages | Collapse All Messages