Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6760)

Issue 6022058: Fix 64-bit build on Mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by epoger
Modified:
12 years, 8 months ago
Reviewers:
caryclark1, reed1
CC:
skia-review_googlegroups.com, mmaerean
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix 64-bit build on Mac BUG=http://code.google.com/p/skia/issues/detail?id=524 Thanks to mmaerean@adobe.com for the patch. Committed: https://code.google.com/p/skia/source/detail?r=3686

Patch Set 1 #

Patch Set 2 : use uintptr_t instead of size_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkFontHost.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
epoger
12 years, 8 months ago (2012-04-16 14:46:53 UTC) #1
epoger
Cary recommends uintptr_t instead of size_t. I have confirmed that this does fix the build... ...
12 years, 8 months ago (2012-04-16 14:55:45 UTC) #2
caryclark1
lgtm
12 years, 8 months ago (2012-04-16 15:01:23 UTC) #3
reed1
No. SkFontTableTag is meant to mirror data in a truetype font, which is always 4-bytes. ...
12 years, 8 months ago (2012-04-16 17:22:04 UTC) #4
epoger
Cary is going to make a new CL that resolves this properly.
12 years, 8 months ago (2012-04-16 17:31:49 UTC) #5
epoger
12 years, 8 months ago (2012-04-16 17:57:58 UTC) #6
On 2012/04/16 17:31:49, epoger wrote:
> Cary is going to make a new CL that resolves this properly.

see https://codereview.appspot.com/6038053/ ('Add cast to support 64 bit.') for
the new changes
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b