Issue 6022058: Fix 64-bit build on Mac

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6022058: Fix 64-bit build on Mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by epoger

Modified:
12 years, 2 months ago

Reviewers:
caryclark1, reed1

CC:
skia-review_googlegroups.com, mmaerean

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix 64-bit build on Mac BUG=http://code.google.com/p/skia/issues/detail?id=524 Thanks to mmaerean@adobe.com for the patch. Committed: https://code.google.com/p/skia/source/detail?r=3686

Patch Set 1 #

Patch Set 2 : use uintptr_t instead of size_t #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/core/SkFontHost.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

epoger

Cary recommends uintptr_t instead of size_t. I have confirmed that this does fix the build... ...

12 years, 2 months ago (2012-04-16 14:55:45 UTC) #2

reed1

No. SkFontTableTag is meant to mirror data in a truetype font, which is always 4-bytes. ...

12 years, 2 months ago (2012-04-16 17:22:04 UTC) #4

epoger

Cary is going to make a new CL that resolves this properly.

12 years, 2 months ago (2012-04-16 17:31:49 UTC) #5

epoger

12 years, 2 months ago (2012-04-16 17:57:58 UTC) #6

On 2012/04/16 17:31:49, epoger wrote:
> Cary is going to make a new CL that resolves this properly.

see https://codereview.appspot.com/6038053/ ('Add cast to support 64 bit.') for
the new changes

Expand All Messages | Collapse All Messages