Issue 6022044: Fix the order of arguments in NameOwnerChanged

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6022044: Fix the order of arguments in NameOwnerChanged (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by fujiwara

Modified:
12 years, 7 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix the order of arguments in NameOwnerChanged BUG=RH#799571 TEST=Linux desktop

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with message #2. #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	ui/gtk3/application.vala	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

12 years, 7 months ago (2012-04-13 15:06:39 UTC) #2

LGTM with a comment

https://codereview.appspot.com/6022044/diff/1/ui/gtk3/application.vala
File ui/gtk3/application.vala (right):

https://codereview.appspot.com/6022044/diff/1/ui/gtk3/application.vala#newcod...
ui/gtk3/application.vala:120: debug("new_owner has name? %s", (new_owner !=
"").to_string());
Remove the debug

Expand All Messages | Collapse All Messages