Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(374)

Issue 6021047: Revert gm baseline deletions from r3653 and r3656, so I can rebaseline them with proper diffs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by epoger
Modified:
12 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Revert gm baseline deletions from r3653 and r3656, so I can rebaseline them with proper diffs Committed: https://code.google.com/p/skia/source/detail?r=3673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-13 lines, --13 lines) Patch
A + gm/base-linux-fixed/strokes_round_4444.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-linux-fixed/strokes_round_565.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-linux-fixed/strokes_round_8888.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-macmini-fixed/strokes_round_4444.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-macmini-fixed/strokes_round_565.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-macmini-fixed/strokes_round_8888.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-macmini-lion-fixed/strokes_round_4444.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-macmini-lion-fixed/strokes_round_565.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-macmini-lion-fixed/strokes_round_8888.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-macmini-lion-float/shadertext_gpu.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-win-fixed/strokes_round_4444.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-win-fixed/strokes_round_565.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/base-win-fixed/strokes_round_8888.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2
epoger
Mike- I'm not going to commit this CL now. Here's what I would like to ...
12 years, 7 months ago (2012-04-12 18:12:27 UTC) #1
reed1
12 years, 7 months ago (2012-04-12 18:27:21 UTC) #2
sgtm

On Thu, Apr 12, 2012 at 2:12 PM, <epoger@google.com> wrote:

> Reviewers: reed1,
>
> Message:
> Mike- I'm not going to commit this CL now.  Here's what I would like to
> do, with you, tomorrow morning:
>
> 1. commit this CL
> 2. watch the buildbots start to turn red again
> 3. run the improved, simplified rebaseline process to commit new images
>
> Sound good?
>
> Description:
> Revert gm baseline deletions from r3653 and r3656, so I can rebaseline
> them with proper diffs
>
> Please review this at
https://codereview.appspot.**com/6021047/<https://codereview.appspot.com/6021...
>
> Affected files:
>  A  +  gm/base-linux-fixed/strokes_**round_4444.png
>  A  +  gm/base-linux-fixed/strokes_**round_565.png
>  A  +  gm/base-linux-fixed/strokes_**round_8888.png
>  A  +  gm/base-macmini-fixed/strokes_**round_4444.png
>  A  +  gm/base-macmini-fixed/strokes_**round_565.png
>  A  +  gm/base-macmini-fixed/strokes_**round_8888.png
>  A  +  gm/base-macmini-lion-fixed/**strokes_round_4444.png
>  A  +  gm/base-macmini-lion-fixed/**strokes_round_565.png
>  A  +  gm/base-macmini-lion-fixed/**strokes_round_8888.png
>  A  +  gm/base-macmini-lion-float/**shadertext_gpu.png
>  A  +  gm/base-win-fixed/strokes_**round_4444.png
>  A  +  gm/base-win-fixed/strokes_**round_565.png
>  A  +  gm/base-win-fixed/strokes_**round_8888.png
>
>
> ### BEGIN SVN COPY METADATA
> #$ cp trunk/gm/base-win-fixed/**strokes_round_565.png
> gm/base-win-fixed/strokes_**round_565.png
> #$ cp trunk/gm/base-macmini-lion-**fixed/strokes_round_4444.png
> gm/base-macmini-lion-fixed/**strokes_round_4444.png
> #$ cp trunk/gm/base-macmini-fixed/**strokes_round_565.png
> gm/base-macmini-fixed/strokes_**round_565.png
> #$ cp trunk/gm/base-linux-fixed/**strokes_round_4444.png
> gm/base-linux-fixed/strokes_**round_4444.png
> #$ cp trunk/gm/base-macmini-fixed/**strokes_round_8888.png
> gm/base-macmini-fixed/strokes_**round_8888.png
> #$ cp trunk/gm/base-macmini-lion-**float/shadertext_gpu.png
> gm/base-macmini-lion-float/**shadertext_gpu.png
> #$ cp trunk/gm/base-linux-fixed/**strokes_round_8888.png
> gm/base-linux-fixed/strokes_**round_8888.png
> #$ cp trunk/gm/base-macmini-lion-**fixed/strokes_round_565.png
> gm/base-macmini-lion-fixed/**strokes_round_565.png
> #$ cp trunk/gm/base-macmini-lion-**fixed/strokes_round_8888.png
> gm/base-macmini-lion-fixed/**strokes_round_8888.png
> #$ cp trunk/gm/base-win-fixed/**strokes_round_8888.png
> gm/base-win-fixed/strokes_**round_8888.png
> #$ cp trunk/gm/base-linux-fixed/**strokes_round_565.png
> gm/base-linux-fixed/strokes_**round_565.png
> #$ cp trunk/gm/base-macmini-fixed/**strokes_round_4444.png
> gm/base-macmini-fixed/strokes_**round_4444.png
> #$ cp trunk/gm/base-win-fixed/**strokes_round_4444.png
> gm/base-win-fixed/strokes_**round_4444.png
> ### END SVN COPY METADATA
> Index: gm/base-linux-fixed/strokes_**round_4444.png
> Index: gm/base-linux-fixed/strokes_**round_565.png
> Index: gm/base-linux-fixed/strokes_**round_8888.png
> Index: gm/base-macmini-fixed/strokes_**round_4444.png
> Index: gm/base-macmini-fixed/strokes_**round_565.png
> Index: gm/base-macmini-fixed/strokes_**round_8888.png
> Index: gm/base-macmini-lion-fixed/**strokes_round_4444.png
> Index: gm/base-macmini-lion-fixed/**strokes_round_565.png
> Index: gm/base-macmini-lion-fixed/**strokes_round_8888.png
> Index: gm/base-macmini-lion-float/**shadertext_gpu.png
> Index: gm/base-win-fixed/strokes_**round_4444.png
> Index: gm/base-win-fixed/strokes_**round_565.png
> Index: gm/base-win-fixed/strokes_**round_8888.png
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b