Issue 6011056: Update emulated functions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6011056: Update emulated functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Zhenyao Mo

Modified:
12 years ago

Reviewers:
kbr1, kbr

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Update emulated functions. It turns out there are bugs in our tests, so kbr fixed them a while ago. Now we had another look at the tests, and it turned out some functions we don't have emulate, and some functions we need to also emulate in fragment shaders. BUG= TEST= R=kbr Committed: https://code.google.com/p/angleproject/source/detail?r=1034

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -69 lines)			Patch
M	src/common/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/BuiltInFunctionEmulator.h	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	src/compiler/BuiltInFunctionEmulator.cpp	View	11 chunks	+28 lines, -57 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Zhenyao Mo

Tested on Mac ATI (both 10.6 and 10.7), Win ATI, and Win NVIDIA. Please have ...

12 years ago (2012-04-12 22:51:52 UTC) #1

kbr1

12 years ago (2012-04-12 23:07:09 UTC) #2

LGTM as long as it's been tested thoroughly on the affected platforms. Thanks
for tracking this down.

Expand All Messages | Collapse All Messages