Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 60042: Split expression implementation from API for compatibility. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 9 months ago by beaton
Modified:
16 years, 6 months ago
Reviewers:
shindig.remailer
Base URL:
https://svn.eu.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
M features/src/main/javascript/features/opensocial-data-context/datacontext.js View 1 chunk +7 lines, -1 line 1 comment Download
M java/common/pom.xml View 1 chunk +7 lines, -2 lines 0 comments Download
M java/gadgets/pom.xml View 1 chunk +7 lines, -2 lines 0 comments Download
M java/server/pom.xml View 1 chunk +5 lines, -1 line 0 comments Download
M java/social-api/pom.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M pom.xml View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 2
beaton
Fixes Jetty/Tomcat/JUEL compatibility issues discussed in this thread: http://www.mail-archive.com/shindig-dev@incubator.apache.org/msg10350.html
16 years, 9 months ago (2009-05-05 21:56:16 UTC) #1
ianboston
16 years, 9 months ago (2009-05-06 05:48:29 UTC) #2
LGTM, other than the patch to datacontext.js which I dont quite get.

http://codereview.appspot.com/60042/diff/1/7
File
features/src/main/javascript/features/opensocial-data-context/datacontext.js
(right):

http://codereview.appspot.com/60042/diff/1/7#newcode170
Line 170: }
Did you mean this patch to be included ? Doesnt appear to be related to the JUEL
problem?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b