Issue 60042: Split expression implementation from API for compatibility.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60042: Split expression implementation from API for compatibility. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by beaton

Modified:
16 years, 6 months ago

Reviewers:
shindig.remailer

Base URL:
https://svn.eu.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -8 lines)			Patch
M	features/src/main/javascript/features/opensocial-data-context/datacontext.js	View	1 chunk	+7 lines, -1 line	1 comment	Download
M	java/common/pom.xml	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	java/gadgets/pom.xml	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	java/server/pom.xml	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	java/social-api/pom.xml	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pom.xml	View	2 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

beaton

Fixes Jetty/Tomcat/JUEL compatibility issues discussed in this thread: http://www.mail-archive.com/shindig-dev@incubator.apache.org/msg10350.html

16 years, 9 months ago (2009-05-05 21:56:16 UTC) #1

ianboston

16 years, 9 months ago (2009-05-06 05:48:29 UTC) #2

LGTM, other than the patch to datacontext.js which I dont quite get.

http://codereview.appspot.com/60042/diff/1/7
File
features/src/main/javascript/features/opensocial-data-context/datacontext.js
(right):

http://codereview.appspot.com/60042/diff/1/7#newcode170
Line 170: }
Did you mean this patch to be included ? Doesnt appear to be related to the JUEL
problem?

Expand All Messages | Collapse All Messages