Issue 5999045: Decouple the SkFlattenable from SkReader32/SkWriter32.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5999045: Decouple the SkFlattenable from SkReader32/SkWriter32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by DerekS

Modified:
12 years, 9 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Decouple the SkFlattenable from SkReader32/SkWriter32. The current impl for SkFlattenable read/write buffers is that they extend from SkReader32 and SkWriter32, but that dependency must be abstract if we are to add any other serialization format. Committed: https://code.google.com/p/skia/source/detail?r=3654

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+496 lines, -317 lines)			Patch
M	gyp/core.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkFlattenable.h	View	8 chunks	+81 lines, -25 lines	0 comments	Download
A	include/core/SkOrderedReadBuffer.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	include/core/SkOrderedWriteBuffer.h	View	1 chunk	+59 lines, -0 lines	0 comments	Download
M	include/core/SkReader32.h	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	include/core/SkWriter32.h	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	src/core/SkFlattenable.cpp	View	5 chunks	+6 lines, -229 lines	0 comments	Download
A	src/core/SkOrderedReadBuffer.cpp	View	1 chunk	+106 lines, -0 lines	0 comments	Download
A	src/core/SkOrderedWriteBuffer.cpp	View	1 chunk	+94 lines, -0 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/core/SkPathHeap.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkPictureFlat.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkPictureFlat.cpp	View	4 chunks	+6 lines, -3 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	src/core/SkScalerContext.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkShader.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/Sk1DPathEffect.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/Sk2DPathEffect.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/effects/SkGradientShader.cpp	View	8 chunks	+14 lines, -31 lines	0 comments	Download
M	src/pipe/SkGPipeRead.cpp	View	6 chunks	+7 lines, -6 lines	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View	6 chunks	+6 lines, -5 lines	0 comments	Download
M	tests/ColorFilterTest.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download