Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(231)

Issue 5998048: code review 5998048: src: changes to build on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by akumar
Modified:
13 years, 9 months ago
Reviewers:
John Floren, 0intro
Visibility:
Public.

Description

src: changes to build on Plan 9

Patch Set 1 #

Patch Set 2 : diff -r 8f08ef4568b2 https://code.google.com/p/go #

Patch Set 3 : diff -r 8f08ef4568b2 https://code.google.com/p/go #

Patch Set 4 : diff -r b9cbd32246e3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+983 lines, -48 lines) Patch
A src/all.rc View 1 1 chunk +13 lines, -0 lines 0 comments Download
A src/clean.rc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/cmd/dist/a.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/dist/arg.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/cmd/dist/build.c View 1 14 chunks +94 lines, -40 lines 0 comments Download
M src/cmd/dist/buildgc.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/dist/buildruntime.c View 1 4 chunks +6 lines, -1 line 0 comments Download
M src/cmd/dist/goc2c.c View 1 2 chunks +4 lines, -3 lines 0 comments Download
A src/cmd/dist/plan9.c View 1 2 3 1 chunk +748 lines, -0 lines 0 comments Download
M src/cmd/dist/unix.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/dist/windows.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/prof/main.c View 1 1 chunk +1 line, -1 line 0 comments Download
A src/make.rc View 1 1 chunk +65 lines, -0 lines 0 comments Download
A src/run.rc View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3
akumar
Hello 0intro@gmail.com, john@jfloren.net, I'd like you to review this change to https://code.google.com/p/go
13 years, 9 months ago (2012-04-11 00:32:02 UTC) #1
akumar
This is the updated version that you can apply to Go 1 and beyond. On ...
13 years, 9 months ago (2012-04-11 00:33:10 UTC) #2
John Floren
13 years, 9 months ago (2012-04-11 00:34:16 UTC) #3
Hot damn!
On Apr 10, 2012 5:33 PM, "Akshat Kumar" <seed@mail.nanosouffle.net> wrote:

> This is the updated version that you
> can apply to Go 1 and beyond.
>
> On 10 April 2012 17:32,  <seed@mail.nanosouffle.net> wrote:
> > Reviewers: 0intro, John Floren,
> >
> > Message:
> > Hello 0intro@gmail.com, john@jfloren.net,
> >
> > I'd like you to review this change to
> > https://code.google.com/p/go
> >
> >
> > Description:
> > src: changes to build on Plan 9
> >
> > Please review this at http://codereview.appspot.com/5998048/
> >
> > Affected files:
> >  A src/all.rc
> >  A src/clean.rc
> >  M src/cmd/dist/a.h
> >  M src/cmd/dist/arg.h
> >  M src/cmd/dist/build.c
> >  M src/cmd/dist/buildgc.c
> >  M src/cmd/dist/buildruntime.c
> >  M src/cmd/dist/goc2c.c
> >  M src/cmd/dist/unix.c
> >  M src/cmd/dist/windows.c
> >  M src/cmd/prof/main.c
> >  A src/make.rc
> >  A src/run.rc
> >
> >
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b