Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 5992078: code review 5992078: debug/gosym: in test, use temp binary name in /tmp, and... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by bradfitz
Modified:
10 years, 4 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

debug/gosym: in test, use temp binary name in /tmp, and clean up. This fixes all.bash on shared machines.

Patch Set 1 #

Patch Set 2 : diff -r 512073e3b7f2 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 512073e3b7f2 https://go.googlecode.com/hg #

Patch Set 4 : diff -r aa9954952235 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/pkg/debug/gosym/pclntab_test.go View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
10 years, 4 months ago (2012-04-09 17:56:37 UTC) #1
rsc
LGTM
10 years, 4 months ago (2012-04-09 18:08:52 UTC) #2
bradfitz
10 years, 4 months ago (2012-04-09 18:19:57 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=5e1544310d03 ***

debug/gosym: in test, use temp binary name in /tmp, and clean up.

This fixes all.bash on shared machines.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5992078
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b