Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(240)

Issue 59920043: Issue 1567: [GOAL] Support previewing of feedback session by instructor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by arnold.koroa
Modified:
10 years, 9 months ago
Reviewers:
damith
Visibility:
Public.

Description

Issue 1567: [GOAL] Support previewing of feedback session by instructor

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1139 lines, -54 lines) Patch
M src/main/java/teammates/common/datatransfer/FeedbackSessionQuestionsBundle.java View 1 chunk +9 lines, -0 lines 0 comments Download
M src/main/java/teammates/common/util/Const.java View 2 chunks +3 lines, -0 lines 0 comments Download
M src/main/java/teammates/logic/api/Logic.java View 1 chunk +12 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/ActionFactory.java View 1 chunk +2 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/FeedbackSubmissionEditPageData.java View 1 chunk +16 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorFeedbackEditPageAction.java View 3 chunks +28 lines, -1 line 0 comments Download
M src/main/java/teammates/ui/controller/InstructorFeedbackEditPageData.java View 2 chunks +4 lines, -0 lines 0 comments Download
A src/main/java/teammates/ui/controller/InstructorFeedbackPreviewAsInstructorAction.java View 1 chunk +56 lines, -0 lines 0 comments Download
A src/main/java/teammates/ui/controller/InstructorFeedbackPreviewAsStudentAction.java View 1 chunk +55 lines, -0 lines 0 comments Download
M src/main/webapp/jsp/instructorFeedbackEdit.jsp View 3 chunks +45 lines, -1 line 0 comments Download
M src/main/webapp/jsp/instructorFeedbackSubmissionEdit.jsp View 3 chunks +19 lines, -3 lines 0 comments Download
M src/main/webapp/jsp/studentFeedbackSubmissionEdit.jsp View 3 chunks +20 lines, -4 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java View 5 chunks +35 lines, -3 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackPageUiTest.java View 1 chunk +1 line, -1 line 2 comments Download
M src/test/java/teammates/test/pageobjects/InstructorFeedbackEditPage.java View 4 chunks +31 lines, -0 lines 0 comments Download
M src/test/resources/data/InstructorFeedbackEditPageUiTest.json View 2 chunks +20 lines, -0 lines 0 comments Download
M src/test/resources/data/MashupPageUiTest.json View 1 chunk +27 lines, -0 lines 1 comment Download
M src/test/resources/pages/instructorFeedbackAddSuccess.html View 2 chunks +39 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackEditEmpty.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackEditPublished.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackEditSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackMcqQuestionAddSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackMcqQuestionEditSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackMsqQuestionAddSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackMsqQuestionEditSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackNumScaleQuestionAddSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackNumScaleQuestionEditSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionAddSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionEditSuccess.html View 2 chunks +42 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorFeedbackSubmitPageClosed.html View 1 chunk +0 lines, -3 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackSubmitPageEmpty.html View 1 chunk +0 lines, -3 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackSubmitPageFullyFilled.html View 1 chunk +3 lines, -3 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackSubmitPageModified.html View 1 chunk +3 lines, -3 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackSubmitPageOpen.html View 1 chunk +3 lines, -3 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackSubmitPagePartiallyFilled.html View 1 chunk +3 lines, -3 lines 0 comments Download
A src/test/resources/pages/instructorFeedbackSubmitPagePreview.html View 1 chunk +120 lines, -0 lines 0 comments Download
M src/test/resources/pages/studentFeedbackSubmitPageClosed.html View 1 chunk +0 lines, -3 lines 0 comments Download
M src/test/resources/pages/studentFeedbackSubmitPageEmpty.html View 1 chunk +0 lines, -3 lines 0 comments Download
M src/test/resources/pages/studentFeedbackSubmitPageFullyFilled.html View 1 chunk +1 line, -1 line 0 comments Download
M src/test/resources/pages/studentFeedbackSubmitPageModified.html View 1 chunk +1 line, -1 line 0 comments Download
M src/test/resources/pages/studentFeedbackSubmitPageOpen.html View 1 chunk +1 line, -2 lines 0 comments Download
M src/test/resources/pages/studentFeedbackSubmitPagePartiallyFilled.html View 1 chunk +1 line, -1 line 0 comments Download
A src/test/resources/pages/studentFeedbackSubmitPagePreview.html View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 2
arnold.koroa
https://codereview.appspot.com/59920043/diff/1/src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackPageUiTest.java File src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackPageUiTest.java (right): https://codereview.appspot.com/59920043/diff/1/src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackPageUiTest.java#newcode242 src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackPageUiTest.java:242: newSession.resultsVisibleFromTime = TimeHelper.convertToDate("2016-09-01 11:00 PM UTC"); is there a ...
10 years, 9 months ago (2014-02-04 05:53:19 UTC) #1
damith
10 years, 9 months ago (2014-02-04 06:08:56 UTC) #2
https://codereview.appspot.com/59920043/diff/1/src/test/java/teammates/test/c...
File
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackPageUiTest.java
(right):

https://codereview.appspot.com/59920043/diff/1/src/test/java/teammates/test/c...
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackPageUiTest.java:242:
newSession.resultsVisibleFromTime =  TimeHelper.convertToDate("2016-09-01 11:00
PM UTC");
There should be a better way. Not sure if it is worth the effort though :-p. 
On 2014/02/04 05:53:19, arnold.koroa wrote:
> is there a better way for this? The test failed simply because today is
> 2014-02-02
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b