Issue 5991067: Add SK_SYSTEM_ZLIB define.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5991067: Add SK_SYSTEM_ZLIB define. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by justinlin

Modified:
12 years, 2 months ago

Reviewers:
Steve VanDeBogart, vandebo (use chromium instead)

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add SK_SYSTEM_ZLIB define. Committed: https://code.google.com/p/skia/source/detail?r=3699

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -2 lines)			Patch
M	include/config/SkUserConfig.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	include/core/SkPostConfig.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/core/SkFlate.cpp	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Steve VanDeBogart

With code review, you should click "Publish+Mail Comments" when the CL is ready for review ...

12 years, 2 months ago (2012-04-16 18:49:35 UTC) #1

justinlin

12 years, 2 months ago (2012-04-16 19:05:20 UTC) #2

On 2012/04/16 18:49:35, Steve VanDeBogart wrote:
> With code review, you should click "Publish+Mail Comments" when the CL is
ready
> for review so the reviewers get notified.
> 
> LGTM

Ah, oops didn't know that. Thanks.

Expand All Messages | Collapse All Messages