Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 5988069: Added infrastructure for adding gtest-based tests. I need to use it for the new preprocessor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Alok Priyadarshi
Modified:
12 years, 8 months ago
Reviewers:
kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added infrastructure for adding gtest-based tests. I need to use it for the new preprocessor. Committed: https://code.google.com/p/angleproject/source/detail?r=1024

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M DEPS View 1 chunk +3 lines, -0 lines 3 comments Download
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
A tests/build_tests.gyp View 1 chunk +36 lines, -0 lines 2 comments Download

Messages

Total messages: 6
Alok Priyadarshi
12 years, 8 months ago (2012-04-09 22:38:43 UTC) #1
kbr1
Thumbs up for more testing. LGTM, but please check the concerns below. http://codereview.appspot.com/5988069/diff/1/DEPS File DEPS ...
12 years, 8 months ago (2012-04-09 22:58:04 UTC) #2
Alok Priyadarshi
http://codereview.appspot.com/5988069/diff/1/DEPS File DEPS (right): http://codereview.appspot.com/5988069/diff/1/DEPS#newcode6 DEPS:6: "http://googletest.googlecode.com/svn/trunk@573", #release 1.6.0 I do not see how this ...
12 years, 8 months ago (2012-04-10 04:14:12 UTC) #3
kbr1
http://codereview.appspot.com/5988069/diff/1/DEPS File DEPS (right): http://codereview.appspot.com/5988069/diff/1/DEPS#newcode6 DEPS:6: "http://googletest.googlecode.com/svn/trunk@573", #release 1.6.0 On 2012/04/10 04:14:12, Alok Priyadarshi wrote: ...
12 years, 8 months ago (2012-04-10 18:26:15 UTC) #4
dgkoch
LGTM. Maybe you could add a wiki page on how to use this, once it's ...
12 years, 8 months ago (2012-04-11 16:05:23 UTC) #5
Alok Priyadarshi
12 years, 8 months ago (2012-04-11 16:21:52 UTC) #6
I will. Thanks.
Please note that I have not added a hand-written build file because you really
need to use gclient to pull googletest into third_party.

On 2012/04/11 16:05:23, dgkoch wrote:
> LGTM. 
> 
> Maybe you could add a wiki page on how to use this, once it's integrated as
> well?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b