Issue 5985051: Guard against null surface in Image::updateSurface.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5985051: Guard against null surface in Image::updateSurface. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Guard against null surface in Image::updateSurface. Committed: https://code.google.com/p/angleproject/source/detail?r=1026

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/libGLESv2/Texture.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

bsalomon

Hi, I encountered this issue while working on http://www.crbug.com/121780. mSurface failed because of OOM. Without ...

12 years, 1 month ago (2012-04-05 18:03:22 UTC) #1

dgkoch

12 years, 1 month ago (2012-04-11 15:24:33 UTC) #2

LGTM (although I expect there might be other places that could run into the same
problem…).