Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(357)

Issue 5979046: code review 5979046: old/regexp, old/template: delete. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by dsymonds
Modified:
8 years, 6 months ago
Reviewers:
CC:
golang-dev, r, rsc, r2, adg
Visibility:
Public.

Description

old/regexp, old/template: delete. Both of these have replacements.

Patch Set 1 #

Patch Set 2 : diff -r e3499bb9ce3d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e3499bb9ce3d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6d5417240a0c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6c742b3b04d1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4449 lines) Patch
M doc/go1.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
R src/pkg/old/regexp/all_test.go View 1 1 chunk +0 lines, -421 lines 0 comments Download
R src/pkg/old/regexp/find_test.go View 1 1 chunk +0 lines, -472 lines 0 comments Download
R src/pkg/old/regexp/regexp.go View 1 1 chunk +0 lines, -1488 lines 0 comments Download
R src/pkg/old/template/doc.go View 1 1 chunk +0 lines, -91 lines 0 comments Download
R src/pkg/old/template/execute.go View 1 1 chunk +0 lines, -346 lines 0 comments Download
R src/pkg/old/template/format.go View 1 1 chunk +0 lines, -77 lines 0 comments Download
R src/pkg/old/template/parse.go View 1 1 chunk +0 lines, -742 lines 0 comments Download
R src/pkg/old/template/template_test.go View 1 1 chunk +0 lines, -810 lines 0 comments Download

Messages

Total messages: 13
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
8 years, 7 months ago (2012-04-01 06:28:58 UTC) #1
r
We said they'd stick around (see go1.html). Is there a problem? -rob
8 years, 7 months ago (2012-04-01 07:26:40 UTC) #2
dsymonds
On Sun, Apr 1, 2012 at 5:26 PM, Rob 'Commander' Pike <r@golang.org> wrote: > We ...
8 years, 7 months ago (2012-04-01 07:40:04 UTC) #3
rsc
On Sun, Apr 1, 2012 at 03:40, David Symonds <dsymonds@golang.org> wrote: > I thought the ...
8 years, 7 months ago (2012-04-02 16:17:17 UTC) #4
r2
On 03/04/2012, at 2:17 AM, Russ Cox wrote: > On Sun, Apr 1, 2012 at ...
8 years, 7 months ago (2012-04-02 20:59:27 UTC) #5
adg
On 3 April 2012 06:59, Rob 'Commander' Pike <r@google.com> wrote: > > On 03/04/2012, at ...
8 years, 7 months ago (2012-04-02 22:42:20 UTC) #6
r2
Again, what's the rush? -rob
8 years, 7 months ago (2012-04-02 22:43:29 UTC) #7
dsymonds
On Tue, Apr 3, 2012 at 8:43 AM, Rob 'Commander' Pike <r@google.com> wrote: > Again, ...
8 years, 7 months ago (2012-04-02 23:19:14 UTC) #8
r2
On 03/04/2012, at 9:19 AM, David Symonds wrote: > On Tue, Apr 3, 2012 at ...
8 years, 7 months ago (2012-04-02 23:50:00 UTC) #9
dsymonds
On Tue, Apr 3, 2012 at 9:49 AM, Rob 'Commander' Pike <r@google.com> wrote: > I ...
8 years, 7 months ago (2012-04-03 01:06:58 UTC) #10
dsymonds
I've updated go1.html to note their outright deletion. I could add the hg commands to ...
8 years, 6 months ago (2012-04-26 03:03:53 UTC) #11
r
LGTM
8 years, 6 months ago (2012-04-27 05:05:59 UTC) #12
dsymonds
8 years, 6 months ago (2012-04-27 05:12:40 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=850cadc5bc9f ***

old/regexp, old/template: delete.

Both of these have replacements.

R=golang-dev, r, rsc, r, adg
CC=golang-dev
http://codereview.appspot.com/5979046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b