Issue 5978058: Don't append '_' to the end of prefix in long name mapping if the original name starts with '_'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5978058: Don't append '_' to the end of prefix in long name mapping if the original name starts with '_' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Zhenyao Mo

Modified:
13 years, 4 months ago

Reviewers:
zmo, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Don't append '_' to the end of prefix in long name mapping if the original name starts with '_' Otherwise we will have '__' which is illegal. Committed: https://code.google.com/p/angleproject/source/detail?r=1044

Patch Set 1 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/common/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/compiler/MapLongVariableNames.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Zhenyao Mo

Daniel, can you review this? A very simple fix as we discussed before.

13 years, 4 months ago (2012-04-16 18:53:50 UTC) #1

dgkoch

On 2012/04/16 18:53:50, Zhenyao Mo wrote: > Daniel, can you review this? A very simple ...

13 years, 4 months ago (2012-04-16 19:57:38 UTC) #2

zmo

On 2012/04/16 19:57:38, dgkoch wrote: > On 2012/04/16 18:53:50, Zhenyao Mo wrote: > > Daniel, ...

13 years, 4 months ago (2012-04-16 20:12:49 UTC) #3

zmo

13 years, 4 months ago (2012-04-16 20:12:51 UTC) #4

On 2012/04/16 19:57:38, dgkoch wrote:
> On 2012/04/16 18:53:50, Zhenyao Mo wrote:
> > Daniel, can you review this?  A very simple fix as we discussed before.
> 
> Is there nothing that depends on the exact form of the new mapping?  If so,
that
> makes it easy and LGTM.

No nothing depends on the form of the mapping.

Expand All Messages | Collapse All Messages