Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 5976072: Added an alternate lexer for the existing preprocessor. It is still behind a compile-time flag. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Alok Priyadarshi
Modified:
13 years, 4 months ago
Reviewers:
kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added an alternate lexer for the existing preprocessor. It is still behind a compile-time flag. Committed: https://code.google.com/p/angleproject/source/detail?r=1019

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -24 lines) Patch
M src/build_angle.gyp View 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/ParseHelper.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/glslang.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/glslang.l View 1 chunk +3 lines, -7 lines 0 comments Download
M src/compiler/glslang_lex.cpp View 3 chunks +5 lines, -9 lines 0 comments Download
A src/compiler/preprocessor/lexer_glue.h View 1 chunk +15 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/lexer_glue.cpp View 1 chunk +147 lines, -0 lines 2 comments Download
M src/compiler/preprocessor/preprocess.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/preprocessor/scanner.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/preprocessor/scanner.c View 3 chunks +22 lines, -0 lines 0 comments Download
M src/compiler/preprocessor/tokens.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
Alok Priyadarshi
I have made good progress on the lexer component for the new preprocessor. I was ...
13 years, 4 months ago (2012-04-03 21:20:42 UTC) #1
kbr1
LGTM http://codereview.appspot.com/5976072/diff/1/src/compiler/preprocessor/lexer_glue.cpp File src/compiler/preprocessor/lexer_glue.cpp (right): http://codereview.appspot.com/5976072/diff/1/src/compiler/preprocessor/lexer_glue.cpp#newcode12 src/compiler/preprocessor/lexer_glue.cpp:12: #include "compiler/preprocessor/new/lexer.h" Shouldn't this be Lexer.h for compilation ...
13 years, 4 months ago (2012-04-03 22:28:56 UTC) #2
Alok Priyadarshi
13 years, 4 months ago (2012-04-05 15:51:45 UTC) #3
What do you guys think about enabling the new lexer by default?

http://codereview.appspot.com/5976072/diff/1/src/compiler/preprocessor/lexer_...
File src/compiler/preprocessor/lexer_glue.cpp (right):

http://codereview.appspot.com/5976072/diff/1/src/compiler/preprocessor/lexer_...
src/compiler/preprocessor/lexer_glue.cpp:12: #include
"compiler/preprocessor/new/lexer.h"
On 2012/04/03 22:28:56, kbr1 wrote:
> Shouldn't this be Lexer.h for compilation on case-sensitive file systems?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b