code review 5970055: cmd/6a, cmd/6l: add support for AES-NI instrutions and ...

cmd/6a, cmd/6l: add support for AES-NI instrutions and PSHUFD
This CL adds support for the these 7 new instructions to 6a/6l in
preparation of the upcoming CL for AES-NI accelerated crypto/aes:
AESENC, AESENCLAST, AESDEC, AESDECLAST, AESIMC, AESKEYGENASSIST, 
and PSHUFD.

[minux1, 2012-09-23 18:49:37]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-09-24 16:33:51]

LGTM

http://codereview.appspot.com/5970055/diff/21007/src/cmd/6l/span.c
File src/cmd/6l/span.c (right):

http://codereview.appspot.com/5970055/diff/21007/src/cmd/6l/span.c#newcode1598
src/cmd/6l/span.c:1598: case Zibxm_r:
I think instead of adding a new Z you can change Zibm_r to have the while loop.
Either way. If you keep this please put it next to the Zibm_r case above and
also move the enum next to the Zibm_r definition in l.h

[minux1, 2012-09-26 17:53:02]

On 2012/09/24 16:33:51, rsc wrote:
http://codereview.appspot.com/5970055/diff/21007/src/cmd/6l/span.c#newcode1598
> src/cmd/6l/span.c:1598: case Zibxm_r:
> I think instead of adding a new Z you can change Zibm_r to have the while
loop.
I reused Zibm_r.

[minux1, 2012-09-26 17:53:23]

*** Submitted as http://code.google.com/p/go/source/detail?r=c2719ae32b09 ***

cmd/6a, cmd/6l: add support for AES-NI instrutions and PSHUFD
This CL adds support for the these 7 new instructions to 6a/6l in
preparation of the upcoming CL for AES-NI accelerated crypto/aes:
AESENC, AESENCLAST, AESDEC, AESDECLAST, AESIMC, AESKEYGENASSIST, 
and PSHUFD.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5970055